Add test coverage for git sources with transitive dependency fallback#9303
Merged
hsbt merged 2 commits intofallback-git-path-sourcesfrom Feb 4, 2026
Merged
Add test coverage for git sources with transitive dependency fallback#9303hsbt merged 2 commits intofallback-git-path-sourcesfrom
hsbt merged 2 commits intofallback-git-path-sourcesfrom
Conversation
4 tasks
Co-authored-by: hsbt <12301+hsbt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on fallback git/path sources implementation
Add test coverage for git sources with transitive dependency fallback
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing regression coverage to ensure Bundler’s transitive dependency fallback behavior works for git-sourced gems (in addition to the existing path-sourced coverage), matching the fix introduced in PR #9301.
Changes:
- Adds a new spec context for a git gem whose transitive dependency is not present in the git source.
- Verifies that during
bundle update, the missing transitive dependency continues to resolve from the default RubyGems source while the parent remains git-sourced.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The original PR #9301 fixed fallback behavior for both Path and Git sources when transitive dependencies don't exist in the source, but only included test coverage for Path sources. Git sources inherit from Path, so the fix applies to both, but lacked regression protection.
What is your fix for the problem, implemented in this PR?
Added parallel test case for git sources mirroring the existing path source test:
Both path and git source tests verify the fix at
bundler/lib/bundler/definition.rb:1080works correctly.Make sure the following tasks are checked
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.